chore: more review feedback #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephanh
reviewed
Aug 20, 2020
stephanh
approved these changes
Aug 26, 2020
stephanh
reviewed
Aug 26, 2020
Co-authored-by: Stephan Hoermann <stephanh@users.noreply.github.com>
stephanh
added a commit
that referenced
this pull request
Aug 31, 2020
* fix comment * remove domainName from DomainAttributes * domainEndpointOptions * support AdvancedSecurityOptions * throw if encryption/https settings aren't enabled * Update packages/@aws-cdk/aws-elasticsearch/lib/domain.ts Co-authored-by: Stephan Hoermann <stephanh@users.noreply.github.com>
stephanh
added a commit
that referenced
this pull request
Sep 20, 2020
* fix comment * remove domainName from DomainAttributes * domainEndpointOptions * support AdvancedSecurityOptions * throw if encryption/https settings aren't enabled * Update packages/@aws-cdk/aws-elasticsearch/lib/domain.ts Co-authored-by: Stephan Hoermann <stephanh@users.noreply.github.com>
stephanh
added a commit
that referenced
this pull request
Sep 30, 2020
* fix comment * remove domainName from DomainAttributes * domainEndpointOptions * support AdvancedSecurityOptions * throw if encryption/https settings aren't enabled * Update packages/@aws-cdk/aws-elasticsearch/lib/domain.ts Co-authored-by: Stephan Hoermann <stephanh@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a few more cleanup items. Also added support for AdvancedSecurityOptions and DomainEndpointOptions.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license