-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Add missing imports #437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing imports #437
Conversation
@@ -22,6 +22,7 @@ | |||
// THE SOFTWARE. | |||
// | |||
|
|||
import Foundation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the missing dependency here is NSUUID
(I wonder if it's worth making this explicit, instead of doing these catch-all imports)?
import Foundation.NSUUID
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That would be an option. In case of Foundation I wouldn't think that's necessary, it's highly likely all of Foundation are imported elsewhere anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not as an optimization, more as a documentation of the dependencies of the file. But it's not commonly done in Swift/ObjC.
I appreciate @jberkel's suggestions. Any chance you can make the changes before we merge? |
With these changes, there is no needed for @import Foundation in SQLite.h then? |
I think you still need it for the |
Sure, works for me, updated. |
Thanks! |
Adds two imports that become apparent when not compiling the original project, but adding the files directly.