Skip to content

Add missing imports #437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 16, 2016
Merged

Add missing imports #437

merged 3 commits into from
Jun 16, 2016

Conversation

p2
Copy link
Contributor

@p2 p2 commented May 25, 2016

Adds two imports that become apparent when not compiling the original project, but adding the files directly.

@@ -22,6 +22,7 @@
// THE SOFTWARE.
//

import Foundation
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the missing dependency here is NSUUID
(I wonder if it's worth making this explicit, instead of doing these catch-all imports)?

import Foundation.NSUUID

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would be an option. In case of Foundation I wouldn't think that's necessary, it's highly likely all of Foundation are imported elsewhere anyway.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not as an optimization, more as a documentation of the dependencies of the file. But it's not commonly done in Swift/ObjC.

@stephencelis
Copy link
Owner

I appreciate @jberkel's suggestions. Any chance you can make the changes before we merge?

@iNoles
Copy link

iNoles commented May 27, 2016

With these changes, there is no needed for @import Foundation in SQLite.h then?
https://github.com/stephencelis/SQLite.swift/blob/master/SQLite/SQLite.h

@jberkel
Copy link
Collaborator

jberkel commented May 28, 2016

I think you still need it for the FOUNDATION_EXPORT macro

@p2
Copy link
Contributor Author

p2 commented Jun 13, 2016

Sure, works for me, updated.

@stephencelis
Copy link
Owner

Thanks!

@stephencelis stephencelis merged commit 0ff5262 into stephencelis:master Jun 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants