- 
          
- 
                Notifications
    You must be signed in to change notification settings 
- Fork 1.6k
Swift3 #502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Swift3 #502
Changes from all commits
4ff05c6
              4cdfd69
              ed8980c
              775a26c
              1cc0a53
              0aaf650
              2588c44
              b62880e
              9fa5b90
              3df6b05
              90e662e
              494f3c4
              8f9b8a8
              78c7f6a
              aaa07c7
              e9abf03
              f8209be
              33f712d
              1837266
              4ed14ad
              2c9fd0c
              8f8eec7
              b6941cd
              f7d017d
              6bf844a
              1549062
              5bc521e
              f11f6b8
              6152ee3
              bbab401
              96238f5
              b392eaf
              8ba973e
              681e219
              db8f39b
              6b4cb81
              File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | 
|---|---|---|
| @@ -0,0 +1 @@ | ||
| 3.0 | 
| Original file line number | Diff line number | Diff line change | 
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| module CSQLite [system] { | ||
| header "/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS10.0.sdk/usr/include/sqlite3.h" | ||
| export * | ||
| } | ||
| Original file line number | Diff line number | Diff line change | 
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| module CSQLite [system] { | ||
| header "/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator10.0.sdk/usr/include/sqlite3.h" | ||
| There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. As above, this causes build errors for all users who don't have their copy of Xcode 8.x at that path. | ||
| export * | ||
| } | ||
| Original file line number | Diff line number | Diff line change | 
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| module CSQLite [system] { | ||
| header "/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.11.sdk/usr/include/sqlite3.h" | ||
| There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. As above, this causes build errors for all users who don't have their copy of Xcode 8.x at that path. | ||
| export * | ||
| } | ||
| Original file line number | Diff line number | Diff line change | 
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| module CSQLite [system] { | ||
| header "/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.12.sdk/usr/include/sqlite3.h" | ||
| There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. As above, this causes build errors for all users who don't have their copy of Xcode 8.x at that path. | ||
| export * | ||
| } | ||
| Original file line number | Diff line number | Diff line change | 
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| module CSQLite [system] { | ||
| header "/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.11.sdk/usr/include/sqlite3.h" | ||
| header "/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/sqlite3.h" | ||
| There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. As above, this causes build errors for all users who don't have their copy of Xcode 8.x at that path. | ||
| export * | ||
| } | ||
| Original file line number | Diff line number | Diff line change | 
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| source 'https://rubygems.org' | ||
|  | ||
| gem 'cocoapods' | ||
| gem 'cocoapods', '~> 1.1.0.rc.2' | ||
| gem 'minitest' | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This hard-coding of the Xcode path causes build errors (Carthage, CocoaPods or just building in Xcode) for all users who don't have their copy of Xcode 8.x at that path.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you suggest to do instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This hard-coding is required for CocoaPods. If you include SQLite.swift as a sub-project or via Carthage it uses an SDK-relative path instead.
I've raised this issue with CocoaPods in the past: CocoaPods/CocoaPods#3942
We're always open to alternative solutions for CocoaPods users, though, and would happily take contributions that solve the problem more elegantly for them!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stephencelis this also affects Carthage builds – without the modulemap, the
CSQLiteimports cannot be resolved. Even worse, they're still required after the framework has been built (see #492).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
think this is solved now with db8f39b