Skip to content

Commit

Permalink
tests: Add missing 'go:build' conditional compilation directives
Browse files Browse the repository at this point in the history
So these integration tests aren't run as part of unit tests. Files
identified using the following Silver Searcher invocation:

  ag -L 'go:build' -G '.*_test.go' internal/

...which found all files in 'internal/' that *did not* contain
'go:build' but *did* end in '_test.go'. This was followed by:

  ag 'go:build acceptance$' -G '.*_test.go' internal/

...which found all files in 'internal/' that only contained 'go:build
acceptance' (i.e. no service-specific suffix) ending in '_test.go'.

Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
  • Loading branch information
stephenfin committed Apr 2, 2024
1 parent 862a540 commit f2f1f68
Show file tree
Hide file tree
Showing 103 changed files with 121 additions and 85 deletions.
2 changes: 2 additions & 0 deletions internal/acceptance/clients/testing/conditions_test.go
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
//go:build acceptance

package testing

import (
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
//go:build acceptance || baremetal || httpbasic

package httpbasic

import (
Expand Down
2 changes: 2 additions & 0 deletions internal/acceptance/openstack/baremetal/noauth/nodes_test.go
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
//go:build acceptance || baremetal || noauth

package noauth

import (
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
//go:build acceptance || blockstorage
//go:build acceptance || blockstorage || apiversions

package blockstorage

Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
//go:build acceptance || blockstorage
//go:build acceptance || blockstorage || snapshots

package noauth

Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
//go:build acceptance || blockstorage
//go:build acceptance || blockstorage || volumes

package noauth

Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
//go:build acceptance || blockstorage
//go:build acceptance || blockstorage || backups

package v2

Expand Down
2 changes: 2 additions & 0 deletions internal/acceptance/openstack/blockstorage/v2/limits_test.go
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
//go:build acceptance || blockstorage || limits

package v2

import (
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
//go:build acceptance || blockstorage
//go:build acceptance || blockstorage || schedulerhints

package v2

Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
//go:build acceptance || blockstorage
//go:build acceptance || blockstorage || schedulerstats

package v2

Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
//go:build acceptance || blockstorage
//go:build acceptance || blockstorage || services

package v2

Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
//go:build acceptance || blockstorage
//go:build acceptance || blockstorage || snapshots

package v2

Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
//go:build acceptance || blockstorage
//go:build acceptance || blockstorage || volumes

package v2

Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
//go:build acceptance || blockstorage
//go:build acceptance || blockstorage || volumetenants

package v2

Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
//go:build acceptance || blockstorage
//go:build acceptance || blockstorage || backups

package v3

Expand Down
2 changes: 2 additions & 0 deletions internal/acceptance/openstack/blockstorage/v3/limits_test.go
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
//go:build acceptance || blockstorage || limits

package v3

import (
Expand Down
2 changes: 2 additions & 0 deletions internal/acceptance/openstack/blockstorage/v3/qos_test.go
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
//go:build acceptance || blockstorage || qos

package v3

import (
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
//go:build acceptance || quotasets
//go:build acceptance || blockstorage || quotasets

package v3

Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
//go:build acceptance || blockstorage
//go:build acceptance || blockstorage || schedulerhints

package v3

Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
//go:build acceptance || blockstorage
//go:build acceptance || blockstorage || schedulerstats

package v3

Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
//go:build acceptance || blockstorage
//go:build acceptance || blockstorage || services

package v3

Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
//go:build acceptance || blockstorage
//go:build acceptance || blockstorage || snapshots

package v3

Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
//go:build acceptance || blockstorage
//go:build acceptance || blockstorage || volumeattachments

package v3

Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
//go:build acceptance || blockstorage
//go:build acceptance || blockstorage || volumes

package v3

Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
//go:build acceptance || blockstorage
//go:build acceptance || blockstorage || volumetenants

package v3

Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
//go:build acceptance || blockstorage
//go:build acceptance || blockstorage || volumetypes

package v3

Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
//go:build acceptance || containerinfra
//go:build acceptance || containerinfra || certificates

package v1

Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
//go:build acceptance || containerinfra
//go:build acceptance || containerinfra || clusters

package v1

Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
//go:build acceptance || containerinfra
//go:build acceptance || containerinfra || clustertemplates

package v1

Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
//go:build acceptance || containerinfra
//go:build acceptance || containerinfra || nodegroups

package v1

Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
//go:build acceptance || containerinfra
//go:build acceptance || containerinfra || quotas

package v1

Expand Down
2 changes: 1 addition & 1 deletion internal/acceptance/openstack/db/v1/configurations_test.go
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
//go:build acceptance || db
//go:build acceptance || db || configurations

package v1

Expand Down
2 changes: 1 addition & 1 deletion internal/acceptance/openstack/db/v1/databases_test.go
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
//go:build acceptance || db
//go:build acceptance || db || databases

package v1

Expand Down
2 changes: 1 addition & 1 deletion internal/acceptance/openstack/db/v1/flavors_test.go
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
//go:build acceptance || db
//go:build acceptance || db || flavors

package v1

Expand Down
2 changes: 1 addition & 1 deletion internal/acceptance/openstack/db/v1/instances_test.go
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
//go:build acceptance || db
//go:build acceptance || db || instances

package v1

Expand Down
2 changes: 1 addition & 1 deletion internal/acceptance/openstack/db/v1/users_test.go
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
//go:build acceptance || db
//go:build acceptance || db || users

package v1

Expand Down
2 changes: 1 addition & 1 deletion internal/acceptance/openstack/dns/v2/recordsets_test.go
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
//go:build acceptance
//go:build acceptance || dns || recordsets

package v2

Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
//go:build acceptance || identity
//go:build acceptance || identity || extensions

package v2

Expand Down
2 changes: 1 addition & 1 deletion internal/acceptance/openstack/identity/v2/tenant_test.go
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
//go:build acceptance || identity
//go:build acceptance || identity || tenants

package v2

Expand Down
2 changes: 1 addition & 1 deletion internal/acceptance/openstack/identity/v2/token_test.go
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
//go:build acceptance || identity
//go:build acceptance || identity || tokens

package v2

Expand Down
2 changes: 1 addition & 1 deletion internal/acceptance/openstack/identity/v2/user_test.go
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
//go:build acceptance || identity
//go:build acceptance || identity || users

package v2

Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
//go:build acceptance
//go:build acceptance || identity || applicationcredentials

package v3

Expand Down
2 changes: 2 additions & 0 deletions internal/acceptance/openstack/identity/v3/catalog_test.go
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
//go:build acceptance || identity || catalog

package v3

import (
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
//go:build acceptance
//go:build acceptance || identity || credentials

package v3

Expand Down
2 changes: 1 addition & 1 deletion internal/acceptance/openstack/identity/v3/domains_test.go
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
//go:build acceptance
//go:build acceptance || identity || domains

package v3

Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
//go:build acceptance
//go:build acceptance || identity || ec2credentials

package v3

Expand Down
2 changes: 1 addition & 1 deletion internal/acceptance/openstack/identity/v3/endpoint_test.go
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
//go:build acceptance
//go:build acceptance || identity || endpoints

package v3

Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
//go:build acceptance
//go:build acceptance || identity || federation

package v3

Expand Down
2 changes: 1 addition & 1 deletion internal/acceptance/openstack/identity/v3/groups_test.go
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
//go:build acceptance
//go:build acceptance || identity || groups

package v3

Expand Down
2 changes: 1 addition & 1 deletion internal/acceptance/openstack/identity/v3/limits_test.go
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
//go:build acceptance
//go:build acceptance || identity || limits

package v3

Expand Down
2 changes: 1 addition & 1 deletion internal/acceptance/openstack/identity/v3/oauth1_test.go
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
//go:build acceptance
//go:build acceptance || identity || oauth1

package v3

Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
//go:build acceptance
//go:build acceptance || identity || osinherit

package v3

Expand Down
2 changes: 1 addition & 1 deletion internal/acceptance/openstack/identity/v3/policies_test.go
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
//go:build acceptance
//go:build acceptance || identity || policies

package v3

Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
//go:build acceptance
//go:build acceptance || identity || projectendpoints

package v3

Expand Down
2 changes: 1 addition & 1 deletion internal/acceptance/openstack/identity/v3/projects_test.go
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
//go:build acceptance
//go:build acceptance || identity || projects

package v3

Expand Down
2 changes: 1 addition & 1 deletion internal/acceptance/openstack/identity/v3/reauth_test.go
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
//go:build acceptance
//go:build acceptance || identity || reauth

package v3

Expand Down
2 changes: 1 addition & 1 deletion internal/acceptance/openstack/identity/v3/regions_test.go
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
//go:build acceptance
//go:build acceptance || identity || regions

package v3

Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
//go:build acceptance
//go:build acceptance || identity || registeredlimits

package v3

Expand Down
2 changes: 1 addition & 1 deletion internal/acceptance/openstack/identity/v3/roles_test.go
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
//go:build acceptance
//go:build acceptance || identity || roles

package v3

Expand Down
2 changes: 1 addition & 1 deletion internal/acceptance/openstack/identity/v3/service_test.go
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
//go:build acceptance
//go:build acceptance || identity || services

package v3

Expand Down
2 changes: 1 addition & 1 deletion internal/acceptance/openstack/identity/v3/token_test.go
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
//go:build acceptance
//go:build acceptance || identity || tokens

package v3

Expand Down
2 changes: 1 addition & 1 deletion internal/acceptance/openstack/identity/v3/users_test.go
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
//go:build acceptance
//go:build acceptance || identity || users

package v3

Expand Down
2 changes: 2 additions & 0 deletions internal/acceptance/openstack/image/v2/imagedata_test.go
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
//go:build acceptance || image || imagedata

package v2

import (
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
//go:build acceptance || networking
//go:build acceptance || networking || apiversion

package v2

Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
//go:build acceptance || networking || bgp || peers

package peers

import (
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
//go:build acceptance || networking || bgp || speakers

package speakers

import (
Expand Down
Loading

0 comments on commit f2f1f68

Please sign in to comment.