fix(Schema generation): ensure Buffer api is only used when in nodejs…

… environment
stephenh · Nov 10, 2024 · 6dcb434 · 6dcb434
1 parent 38b114c
commit 6dcb434
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 4 deletions.
diff --git a/integration/options/options.ts b/integration/options/options.ts
diff --git a/src/schema.ts b/src/schema.ts
@@ -11,7 +11,7 @@ import SourceInfo from "./sourceInfo";
 import { impFile, maybePrefixPackage } from "./utils";
 import { basicTypeName, toReaderCall } from "./types";
 import { BinaryReader } from "@bufbuild/protobuf/wire";
-import { OutputSchemaOption } from "./options";
+import { EnvOption, OutputSchemaOption } from "./options";
 
 const fileDescriptorProto = imp("FileDescriptorProto@ts-proto-descriptors");
 
@@ -216,7 +216,11 @@ function getExtensionValue(ctx: Context, extension: FieldDescriptorProto, data:
       }),
     );
     const result = resultBuffer.toString("base64");
-    return code`'${extension.name}': ${typeName}.decode(Buffer.from('${result}', 'base64'))`;
+    const encoded =
+      ctx.options.env === EnvOption.NODE
+        ? code`Buffer.from(${ctx.utils.bytesFromBase64}("${result}")`
+        : code`${ctx.utils.bytesFromBase64}("${result}")`;
+    return code`'${extension.name}': ${typeName}.decode(${encoded})`;
   } else {
     const reader = new BinaryReader(data[0]);
     let value = (reader as any)[toReaderCall(extension)]();