Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generated affixes #1033

Closed
oliveryasuna opened this issue Apr 17, 2024 · 5 comments · Fixed by #1069 · May be fixed by habyyb/CD-AdvancedDigitalIQ#3
Closed

Generated affixes #1033

oliveryasuna opened this issue Apr 17, 2024 · 5 comments · Fixed by #1069 · May be fixed by habyyb/CD-AdvancedDigitalIQ#3
Labels
released

Comments

@oliveryasuna
Copy link
Contributor

It would be useful is there was an option to add prefixes and suffixes to generated messages.

I am using protobufs as the encoding for bodies in HTTP requests/responses (no gRPC). So, in a way, the generated types represent DTOs. It would be useful if I could have the generator append Dto to make that clear in code.
@stephenh
Copy link
Owner

Hi @oliveryasuna , that seems like a simple addition; if you'd like to work on a PR, that'd be great. Thanks!

@oliveryasuna
Copy link
Contributor Author

@stephenh Yes, I will open a PR tonight.

@oliveryasuna
Copy link
Contributor Author

oliveryasuna commented Jun 30, 2024 •
edited
Loading

@stephenh Side note: You should add a "good first issue" label to simple issues. It's a good indicator for developers looking to contribute.

@oliveryasuna
Copy link
Contributor Author

#1069

@oliveryasuna oliveryasuna mentioned this issue Jul 1, 2024
Merged
stephenh pushed a commit that referenced this issue Jul 1, 2024
@oliveryasuna
feat: added the "typePrefix" and "typeSuffix" options. (#1069)
ab515cd 
Fixes #1033
stephenh pushed a commit that referenced this issue Jul 1, 2024
@semantic-release-bot
chore(release): 1.181.0 [skip ci]
c5546fb 
# [1.181.0](v1.180.0...v1.181.0) (2024-07-01)

### Features

* added the "typePrefix" and "typeSuffix" options. ([#1069](#1069)) ([ab515cd](ab515cd)), closes [#1033](#1033)
@stephenh
Copy link
Owner

stephenh commented Jul 1, 2024

🎉 This issue has been resolved in version 1.181.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@SoniaBoussabeh SoniaBoussabeh mentioned this issue Sep 11, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
2 participants
@stephenh @oliveryasuna