Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

google.protobuf.BytesValue generates invalid code for fromJSON method #155

Closed
ebakoba opened this issue Oct 15, 2020 · 1 comment
Closed

Comments

@ebakoba
Copy link
Contributor

ebakoba commented Oct 15, 2020

Example message like:

message SomeMessage = {
  google.protobuf.BytesValue someBytes = 1;
}

generates following line the fromJSON method for that message:

message.someBytes = Uint8Array(object.someBytes);

For valid code, keyword called new should be added, resulting in:

message.someBytes = new Uint8Array(object.someBytes);
@stephenh
Copy link
Owner

stephenh commented Feb 6, 2021

Fixed in v1.54.0. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants