Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong generation when package not set #273

Closed
kilimnik opened this issue Apr 16, 2021 · 1 comment
Closed

Wrong generation when package not set #273

kilimnik opened this issue Apr 16, 2021 · 1 comment

Comments

@kilimnik
Copy link
Contributor

The protobuf specs allow to not specify a package. Your generator assumes that a package is always defined.
e.g. there is this line of code in the grpc web generator serviceName: "${fileDesc.package}.${serviceDesc.name}", No matter the package it always puts a dot in front of the service name. This doen't work when dealing with an empty package name as the service name would be .ExampleService.

@stephenh
Copy link
Owner

Should be out in the next release, thanks!

zfy0701 added a commit to sentioxyz/ts-proto that referenced this issue Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants