Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Request: Longs as BigInts #64

Closed
jeffpyke opened this issue May 13, 2020 · 3 comments
Closed

Feature Request: Longs as BigInts #64

jeffpyke opened this issue May 13, 2020 · 3 comments

Comments

@jeffpyke
Copy link
Contributor

Feature request: In addition to the Long library, add ability to type longs as BigInts.
@stephenh stephenh mentioned this issue Oct 31, 2021
Closed
@eba-ts
Copy link

eba-ts commented Aug 19, 2022 •
edited
Loading

+1. Many years ago we chose to code UUID as 2x64 bit integers. The option--ts_proto_opt=forceLong=Long made it work, it would be nice to have BigInt.

message UUID {
    required fixed64 least_sign_bits = 1 
    required fixed64 most_sign_bits = 2 
}

@aikoven aikoven mentioned this issue Dec 3, 2022
Closed
@azizghuloum
Copy link
Contributor

#742

@stephenh
Copy link
Owner

This was fixed by #742 ; thanks @azizghuloum !

Also filed #744 as a follow up.

zfy0701 added a commit to sentioxyz/ts-proto that referenced this issue Jan 5, 2023
@zfy0701
refactor(test): extract common test compoennt for future improve (ste…
aa511cf 
…phenh#64)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@stephenh @jeffpyke @eba-ts @azizghuloum