Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add options to limit generation of encode and decode methods to only specific message types #1085

Merged

Conversation

akrennmair
Copy link
Contributor

I created this PR as a possible to solution to the feature request submitted in #1084.

I added integration tests for test coverage, and updated the documentation to include the two new options.

@stephenh
Copy link
Owner

stephenh commented Dec 2, 2024

Hi @akrennmair , thanks for updating the PR! Looks like there is a build error with MessageFns...maybe we need two/separate input/output MessageFns types?

@akrennmair
Copy link
Contributor Author

@stephenh I didn't want to touch the MessageFns type as I didn't know what it would break. What I did instead was to generate a tiny dummy encode or decode method that throws an error if the presence of the method is required.

@stephenh
Copy link
Owner

stephenh commented Dec 3, 2024

Sounds great, thanks @akrennmair !

@stephenh stephenh merged commit c7372fa into stephenh:main Dec 3, 2024
6 checks passed
stephenh pushed a commit that referenced this pull request Dec 3, 2024
# [2.5.0](v2.4.2...v2.5.0) (2024-12-03)

### Features

* Add options to limit generation of encode and decode methods to only specific message types ([#1085](#1085)) ([c7372fa](c7372fa)), closes [#1084](#1084)
@stephenh
Copy link
Owner

stephenh commented Dec 3, 2024

🎉 This issue has been resolved in version 2.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants