Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Same commit message twice for each deploy #10

Closed
pdewouters opened this issue Sep 2, 2014 · 4 comments
Closed

Same commit message twice for each deploy #10

pdewouters opened this issue Sep 2, 2014 · 4 comments

Comments

@pdewouters
Copy link

screenshot 2014-09-02 10 04 27

@stephenharris
Copy link
Owner

The trunk and tag folders are committed separately, but with the same message. Additionally assets are also committed, so potentially it may appear three times.

I have to admit I never even look at WordPress' SVN repository any more, so this isn't a massive concern for me. Would a commit message such as "Committing X into Trunk/Tag" or "Tagging X" and "Committing X to trunk" be preferable?

@pdewouters
Copy link
Author

Yeah, that would be acceptable :)

@stephenharris
Copy link
Owner

How would this fit with #9?

I feel if there's to be three separate commit messages, it might be easier to fix this as:

  • "Committing X to trunk"
  • "Tagging X"
  • "Committing assets for X"

Other option would be to expose options for all three of these messages, but after giving it some thought, I'm not convinced of the benefit of having user-specified static messages. Potentially you could prompt the user for commit message for each...? Perhaps, also, with a flag to disable that prompt. Personally I have no interest in supplying an informative SVN messages, for the purposes of wp.org, it's not version control and not something I use beyond deploying a new version...

@stephenharris
Copy link
Owner

This if fixed in 1.1.0 (sorry for the delay, the update had be sitting, forgotten, on my hard drive)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants