Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix removeEventListener calls #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

scyclops
Copy link

@scyclops scyclops commented May 2, 2019

No description provided.

@stephenkingsley
Copy link
Owner

stephenkingsley commented May 7, 2019

I don't know why you were set passive false? Cause if you do not set passive, event.preventDefault() will be call as normal.

ps. you can click this link

image

@scyclops
Copy link
Author

scyclops commented May 7, 2019

I only set passive to false in the removeEventListener calls because the addEventListener calls in the existing code have passive set to false. This pull request doesn't change the addEventListener calls. But for removeEventListener calls to work, they must have the same arguments as the calls to addEventListener.

https://developer.mozilla.org/en-US/docs/Web/API/EventTarget/removeEventListener

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants