Skip to content

Fix .travis.yml #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 20, 2012
Merged

Fix .travis.yml #29

merged 1 commit into from
Apr 20, 2012

Conversation

nanonyme
Copy link
Contributor

The apt-get command is mistakenly as before_script when it should be before_install. This causes the headers not to be available when pip is run which causes pip to fail.

@nanonyme nanonyme mentioned this pull request Apr 19, 2012
stephenmcd added a commit that referenced this pull request Apr 20, 2012
@stephenmcd stephenmcd merged commit a2509e8 into stephenmcd:master Apr 20, 2012
@stephenmcd
Copy link
Owner

Thank you soooo much! I couldn't figure this out.

@nanonyme
Copy link
Contributor Author

No problem. I was considering using this library myself so reviewing the CI configuration felt like worth the effort.

@stephenmcd
Copy link
Owner

Cool man. If you check out the top of the README you'll see that the version of socket.io it works against is somewhat out of date. Issue #19 includes the initial work for bringing things up to date, but it's not finished yet. The only thing blocking this is finding the time to do it unfortunately. So if you're keen on helping out there's work to be done there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants