-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New feature: custom favicon and styles #120
base: master
Are you sure you want to change the base?
Conversation
This pull request is being automatically deployed with Vercel (learn more). csb-vydqj – ./🔍 Inspect: https://vercel.com/stephenou/csb-vydqj/4BnQowi6ndFfGQkAbhAupX37td51 fruition – ./🔍 Inspect: https://vercel.com/stephenou/fruition/6guft3zt5vVZMxqKXqZSmWYLApQP |
@isjair that's a good point, thanks for notice. I'm actually copy-pasting this code manually on Cloudflare workers, will try to update the code generator to reflect this. |
very grateful, excellent news. Cheers |
@@ -23,7 +23,13 @@ const PAGE_DESCRIPTION = | |||
/* Step 4: enter a Google Font name, you can choose from https://fonts.google.com */ | |||
const GOOGLE_FONT = "Rubik"; | |||
|
|||
/* Step 5: enter any custom scripts you'd like */ | |||
/* Step 5: Add a custom favicon (your Notion avatar URL works too) */ | |||
const CUSTOM_AVATAR = ""; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello, this section manually works for me,
pd: the only thing that does not come out to the main script?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, could you tell me how it worked? I rewrote it but cloudflare said script can't be deployed. Is there anything wrong with these code?
/* Step 5: Add a custom favicon (your Notion avatar URL works too) */
const CUSTOM_AVATAR = "";
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
const CUSTOM_AVATAR = ""; | |
const CUSTOM_AVATAR = "<link href="https://uploads-ssl.webflow.com/5f66a66ce4b959957c4e8057/60ec40cd1484673a14eeb4b9_chiali_favicon.png" rel="shortcut icon" type="image/x-icon">"; |
Added two new capabilities: