Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New feature: custom favicon and styles #120

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

pabliqe
Copy link
Contributor

@pabliqe pabliqe commented Aug 21, 2021

Added two new capabilities:

  • CUSTOM_AVATAR allows you to put a image URL to use as a favicon (on every page)
  • CUSTOM_STYLES append custom styles to the current style block without editing original code area.
/* Step 5: Add a custom favicon (your Notion avatar URL works too) */
const CUSTOM_AVATAR = "";

/* Step 6: enter any custom CSS, no style tag needed */
const CUSTOM_STYLE = ``;

@vercel
Copy link

vercel bot commented Aug 21, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

csb-vydqj – ./

🔍 Inspect: https://vercel.com/stephenou/csb-vydqj/4BnQowi6ndFfGQkAbhAupX37td51
✅ Preview: https://csb-vydqj-git-fork-pabliqe-custom-favicons-stephenou.vercel.app

fruition – ./

🔍 Inspect: https://vercel.com/stephenou/fruition/6guft3zt5vVZMxqKXqZSmWYLApQP
✅ Preview: https://fruition-git-fork-pabliqe-custom-favicons-stephenou.vercel.app

@tamagamis
Copy link

image
great, but when generating the code it does not show the option step # 6, do you have to place it manually?

@pabliqe
Copy link
Contributor Author

pabliqe commented Sep 2, 2021

@isjair that's a good point, thanks for notice. I'm actually copy-pasting this code manually on Cloudflare workers, will try to update the code generator to reflect this.

@tamagamis
Copy link

tamagamis commented Sep 2, 2021

@isjair ese es un buen punto, gracias por avisar. De hecho, estoy copiando y pegando este código manualmente en los trabajadores de Cloudflare, intentaré actualizar el generador de código para reflejar esto.

very grateful, excellent news. Cheers

@@ -23,7 +23,13 @@ const PAGE_DESCRIPTION =
/* Step 4: enter a Google Font name, you can choose from https://fonts.google.com */
const GOOGLE_FONT = "Rubik";

/* Step 5: enter any custom scripts you'd like */
/* Step 5: Add a custom favicon (your Notion avatar URL works too) */
const CUSTOM_AVATAR = "";

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, this section manually works for me,

pd: the only thing that does not come out to the main script?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, could you tell me how it worked? I rewrote it but cloudflare said script can't be deployed. Is there anything wrong with these code?

/* Step 5: Add a custom favicon (your Notion avatar URL works too) */
const CUSTOM_AVATAR = "";

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const CUSTOM_AVATAR = "";
const CUSTOM_AVATAR = "<link href="https://uploads-ssl.webflow.com/5f66a66ce4b959957c4e8057/60ec40cd1484673a14eeb4b9_chiali_favicon.png" rel="shortcut icon" type="image/x-icon">";

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants