Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamically set domainBaseURL #140

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

benfoxall
Copy link

This changes the injected config to be set from the window.location instead of being hardcoded.

I think this could resolve config issues like #122 and #137.

This also means that it'll work on *.workers.dev domains and in the "Preview" panel in cloudflare:

Screenshot 2021-10-12 at 14 06 47

@vercel
Copy link

vercel bot commented Oct 12, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

csb-vydqj – ./

🔍 Inspect: https://vercel.com/stephenou/csb-vydqj/4BULpBwjSSTn4P7d2CyTd4AgqCX9
✅ Preview: https://csb-vydqj-git-fork-benfoxall-patch-1-stephenou.vercel.app

fruition – ./

🔍 Inspect: https://vercel.com/stephenou/fruition/9f543QdCo6kXv9sUzYfDrQ1igPnY
✅ Preview: https://fruition-git-fork-benfoxall-patch-1-stephenou.vercel.app

@tamagamis
Copy link

This changes the injected config to be set from the window.location instead of being hardcoded.

I think this could resolve config issues like #122 and #137.

This also means that it'll work on *.workers.dev domains and in the "Preview" panel in cloudflare:

Screenshot 2021-10-12 at 14 06 47

Perfect, just waiting for it to work for the others who had the problem.

@channprj
Copy link

Thank you!

@mohammadnajmuzzaman
Copy link

When will this be merged? Still have the issue at #122

@curious-jane
Copy link

oh. you solved my problem. It works like magic!

1 similar comment
@malinkang
Copy link

oh. you solved my problem. It works like magic!

@notxcain
Copy link

Hey! Thanks that fixed the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants