Adding functionality to choose light theme as default or not #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). csb-vydqj – ./🔍 Inspect: https://vercel.com/stephenou/csb-vydqj/BuBDhp966b56i9CkqiJTz6BhHsof fruition – ./🔍 Inspect: https://vercel.com/stephenou/fruition/FrGgjsNg562MXDrN8yuJdqJwJNes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They say the best way to make a product is to look into your own life and see if that makes a difference. If it does build it. With this PR I hope I make Fruition a little better for everyone.
I had been looking for a way to show my fruition page show up in dark mode by default. So I went ahead and changed the
onLight()call toonDark()call in theaddDarkModeButton()function in theBodyRewriterclass. Then I saw posts on Reddit and Issues that were trying to solve the same problem (#159). So I went ahead and made some changes as suggested.I hope this helps :)
One again thank you for Fruition!