-
Notifications
You must be signed in to change notification settings - Fork 10
Added addScenarioGroup function #45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
@BenjaminPeter the build failed - any idea why? |
@stephens999 not sure - the log indicates the build environment is missing some packages (neither of which I did anything with). Is it possible that some configurations changed?
In general, what is the preferred way to update the package? |
@BenjaminPeter I was going to ask you to re-run roxygen2 to document your function, but you're one step ahead of me. :) I think the build failure was just a sporadic CRAN hiccup. |
great - it passes now. I like the code, but have suggestions for simplification. Specifically I'm wondering whether it might be simpler (and more flexible) to have the addScenarioGroup function so that it |
@stephens999 Not sure if I am understanding you correctly; do you mean instead of having If so, I prefer the current design because I find it more clear because
regarding names, see the recent pull-request. |
Sorry @BenjaminPeter I've been delinquent on merging this. Can you rewrite to respect snake case and I will merge... |
I wrote a function addressing Issue #9 for my own purposes, hopefully it is useful for others.