Fixing undefined reference to 'isnan' '__isinf' for Android NDK 11 #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fix an issue related to the compilation issue of forward declaration for the todolist::Todo. The djinni generates the todo.hpp and todo_list.hpp files. The todo_list.hpp has a forward declaration of the Todo struct. The code in todo_list.hpp before this commit was including the file todo.hpp, but since it is an autogenerated file, it is not recommended to do that. Instead, this commit includes the todo.hpp in the todo_list_impl.hpp. Please, not that this requires an update in the content for the file todo_list_impl.hpp in the tutorial available in [1]. In addition, this commit adds an entry in the Makefile for cleaning the files generated in the compilation process. [1] http://mobilecpptutorials.com/todo-app-using-djinni-and-sqlite-part-1-cplusplus/
This commit fix an issue related to the compilation issue of forward declaration for the todolist::Todo. The djinni generates the todo.hpp and todo_list.hpp files. The todo_list.hpp has a forward declaration of the Todo struct. The code in todo_list.hpp before this commit was including the file todo.hpp, but since it is an autogenerated file, it is not recommended to do that. Instead, this commit includes the todo.hpp in the todo_list_impl.hpp. Please, not that this requires an update in the content for the file todo_list_impl.hpp in the tutorial available in [1]. In addition, this commit adds an entry in the Makefile for cleaning the files generated in the compilation process. [1] http://mobilecpptutorials.com/todo-app-using-djinni-and-sqlite-part-1-cplusplus/
As per [1], android-8 is not supported in Android NDK r11. This commit updates the Application.mk file to avoid error "undefined reference to 'isnan' '__isinf'" while compiling the code for some platforms, such as armeabi-v7a and armeabi. [1] android/ndk#44
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per [1], android-8 is not supported in Android NDK r11. This commit
updates the Application.mk file to avoid error "undefined reference to
'isnan' '__isinf'" while compiling the code for some platforms, such as
armeabi-v7a and armeabi.
[1] android/ndk#44