Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added 3rd option in the World Covid Info. #171

Merged
merged 12 commits into from
Jun 22, 2021

Conversation

stephin007
Copy link
Owner

@stephin007 stephin007 commented Jun 17, 2021

🚨 Please review the guidelines for contributing to this repository.

Please check if the PR fulfills these requirements

  • Make sure you are requesting to NEW-UI. Don't request other protected Branches like staging/master
  • Make sure no conflicts are present in the code, if so please resolve it(Tip: Always fetch upstream)
  • Your Commit messages should make sense.
  • Don't push your package.lock.json as this project uses yarn.lock already.
  • Check your code additions will fail neither code linting checks nor unit test.

Describe your changes

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Enhancement

  • What is the current behavior? (You can also link to an open issue here)
    No extra options

  • What is the new behavior (if this is a feature change)?

Following are the expected Changes to be seen in the UI:

  • Removed one option and updated the second one.

  • Also added horizontal scroll functionality for the user to see the doughnut charts side by side rather scrolling , this gives much better UI Experience

  • Does this PR introduce a breaking change? (i.e changes that may require users to update/refactor existing istances of the application)
    NIL

  • Other Information:

❤️ Thank you!

@stephin007 stephin007 requested a review from Justinnn07 June 17, 2021 18:19
@stephin007 stephin007 self-assigned this Jun 17, 2021
@vercel
Copy link

vercel bot commented Jun 17, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/stephin007/cowin-vaccine-availablity-checker/C4nZpmvTVwMhoFtoyZTc7UVzAfnm
✅ Preview: https://cowin-vaccine-availablity-checker-git-enhance-388cf8-stephin007.vercel.app

@stephin007 stephin007 linked an issue Jun 18, 2021 that may be closed by this pull request
@Justinnn07 Justinnn07 marked this pull request as draft June 18, 2021 17:12
@stephin007 stephin007 changed the title Added 3rd option in the World Covid Info (WORK IN PROGRESS) Added 3rd option in the World Covid Info. Jun 22, 2021
@stephin007 stephin007 marked this pull request as ready for review June 22, 2021 12:42
@stephin007 stephin007 requested review from Justinnn07 and removed request for Justinnn07 June 22, 2021 13:00
@stephin007 stephin007 added enhancement New feature or request good first issue Good for newcomers new feature labels Jun 22, 2021
Copy link
Collaborator

@Justinnn07 Justinnn07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! @stephin007

@Justinnn07 Justinnn07 merged commit 213a957 into NEW-UI Jun 22, 2021
@Justinnn07 Justinnn07 deleted the enhancement/worldCovidInfo branch June 22, 2021 15:21
stephin007 added a commit that referenced this pull request Jun 24, 2021
* Added Scroll to top fucntionality

* added firacode font CDN

* Added 3rd option in the World Covid Info. (#171)

* Added single continent info(WIP)

* Added continent options

* Added 3rd option and added horizontal scroll(WIP)

* removed width css and added text to tell user to swipe to see more data

* removed width css and added text to tell user to swipe to see more data

* added text to p tags

* fixed css for the continent Dropdown

* removed unwanted css

* removed whole continents data/graph

* added check for continent chart
stephin007 added a commit that referenced this pull request Jun 30, 2021
* Added Scroll to top fucntionality

* added firacode font CDN

* Added 3rd option in the World Covid Info. (#171)

* Added single continent info(WIP)

* Added continent options

* Added 3rd option and added horizontal scroll(WIP)

* removed width css and added text to tell user to swipe to see more data

* removed width css and added text to tell user to swipe to see more data

* added text to p tags

* fixed css for the continent Dropdown

* removed unwanted css

* removed whole continents data/graph

* added check for continent chart

* added conflicts workflow  (#173)

* added conflicts workflow 🔨

* added staging to the workflow 🔥

* changed the token name 🔨

* Added the 3rd option for showing per country covid data (#175)

* Added single continent info(WIP)

* Added continent options

* Added 3rd option and added horizontal scroll(WIP)

* removed width css and added text to tell user to swipe to see more data

* removed width css and added text to tell user to swipe to see more data

* added text to p tags

* fixed css for the continent Dropdown

* removed unwanted css

* removed whole continents data/graph

* added check for continent chart

* uncommented the third option

* updated chart content for continent view and removed dataset label

* Added country dropdown for each continent

* Added country flag  for dataReception check

* fixed img tag for vercel deployment error fix

* added the correct jmespath for th destrcutured flag

* added check for empty object for flags

* made continent and country single select responsive

* Added country card for information

* Added country card for information

* fixed css

* Added check for the country right card to be only shown when actual data is fetched

* finalised country card

Co-authored-by: Justin Varghese <69856008+Justinnn07@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add CovidDetails and Vaccination details from around the world.
2 participants