Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added static camera position config option #122

Merged
merged 1 commit into from
Nov 30, 2022
Merged

added static camera position config option #122

merged 1 commit into from
Nov 30, 2022

Conversation

gabor-kovacs
Copy link
Contributor

Added a config option to common.yaml to enable static camera position for position tracking.

Myzhar
Myzhar reviewed Nov 30, 2022
View reviewed changes
Copy link
Member

@Myzhar Myzhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request is ok, but we never took into consideration this feature of the SDK because we expect the camera to be mounted on a moving robot.
Are you using it instead for external analytics in a ROS environment?

@Myzhar Myzhar self-assigned this Nov 30, 2022
@Myzhar Myzhar added the feature_request New feature or request label Nov 30, 2022
@gabor-kovacs
Copy link
Contributor Author

I use a fixed ZED camera in an indoor environment with an industrial robot arm and human workers. ROS2 is used to communicate between the robot and also other sytems. I need to have a fixed coordinate system to track humans in the scene relative to the robot.
Maybe this is a niche case but I tought this feature might be useful to have.

@Myzhar Myzhar self-requested a review November 30, 2022 17:03
@Myzhar
Copy link
Member

Myzhar commented Nov 30, 2022

This seems indeed a possible application that we should make available for everyone.
Thank you for your PR

@Myzhar Myzhar merged commit 72ebe20 into stereolabs:master Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Myzhar Myzhar Myzhar approved these changes

Assignees

@Myzhar Myzhar

Labels
feature_request New feature or request
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gabor-kovacs @Myzhar