Remove depth png image write on grab loop #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Esteban Zamora <esteban.zamora.al@gmail.com>
|
@Myzhar please take a look |
Myzhar
approved these changes
Jun 28, 2023
| @@ -5886,7 +5886,6 @@ void ZedCamera::retrieveVideoDepth() | |||
| sl::ERROR_CODE::SUCCESS == | |||
| mZed.retrieveMeasure(mMatDepth, sl::MEASURE::DEPTH, sl::MEM::CPU, mMatResol); | |||
| mSdkGrabTS = mMatDepth.timestamp; | |||
| mMatDepth.write("depth_map.png"); | |||
There was a problem hiding this comment.
Good catch 👍
This comes from an old debugging session :(
|
The tool you used seems interesting. What did you use? |
|
@Myzhar check this resource regarding flame graphs: https://www.brendangregg.com/FlameGraphs/cpuflamegraphs.html. These are generated from perf profiling data (https://www.brendangregg.com/perf.html#TimedProfiling). The visualizer I used is https://www.speedscope.app/. 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When doing a performance test I found this image write taking most of the CPU cycles for the grab thread loop. Attaching the CPU FlameGraph for reference.