Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADD: Fee Recipient via API #622

Merged
merged 5 commits into from
Sep 1, 2022
Merged

ADD: Fee Recipient via API #622

merged 5 commits into from
Sep 1, 2022

Conversation

NeoPlays
Copy link
Member

@NeoPlays NeoPlays commented Aug 5, 2022

waiting for implementation on client side

@NeoPlays NeoPlays added this to the beta2.0-stack milestone Aug 5, 2022
@NeoPlays NeoPlays added the enhancement Request or proposal for a new feature or enhancement label Aug 5, 2022
@MaxTheGeeek
Copy link
Contributor

@NeoPlays which part of the fee recipient r u working on?
Screenshot 2022-08-06 at 20 16 05

@NeoPlays
Copy link
Member Author

NeoPlays commented Aug 8, 2022

@NeoPlays which part of the fee recipient r u working on? Screenshot 2022-08-06 at 20 16 05

functionality of this thing but the teku client hasn't implemented it yet.. actually it's done already 😅

@NeoPlays NeoPlays closed this Aug 8, 2022
@NeoPlays NeoPlays deleted the recipient branch August 8, 2022 11:49
@NeoPlays NeoPlays restored the recipient branch August 8, 2022 12:04
@NeoPlays NeoPlays reopened this Aug 8, 2022
@stefa2k stefa2k removed this from the beta2.0-stack milestone Aug 9, 2022
@NeoPlays NeoPlays closed this Aug 10, 2022
@NeoPlays NeoPlays deleted the recipient branch August 10, 2022 05:19
@NeoPlays NeoPlays restored the recipient branch August 10, 2022 07:37
@NeoPlays NeoPlays reopened this Aug 10, 2022
@NeoPlays
Copy link
Member Author

NeoPlays commented Aug 31, 2022

i took out the frontend implementation to avoid future conflicts.
I tested the import on:

  • Teku - Response: ""
  • Lighthouse - Response: null
  • Nimbus - Response: ""
  • Prysm - Response: ""

The imports where successful for all clients where i was able to check the fee recipient in a file.
I couldn't find any file for prysm but the api request didn't fail either.
I also tested restarting the containers to check if the --validators-proposer-default-fee-recipient would overright the api import and they don't, so the api has higher priority just like some docs state.

@NeoPlays NeoPlays marked this pull request as ready for review August 31, 2022 11:27
@NeoPlays NeoPlays requested review from gbayasgalan and stefa2k and removed request for gbayasgalan August 31, 2022 11:27
@stefa2k
Copy link
Member

stefa2k commented Aug 31, 2022

lgtm, but somebody with JS experience should look over it too

Copy link
Contributor

@mabasian mabasian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg

@mabasian mabasian merged commit 0edbd41 into stereum-dev:main Sep 1, 2022
@NeoPlays NeoPlays deleted the recipient branch September 2, 2022 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Request or proposal for a new feature or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants