Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What is the Type field value for ACK packets in PGMCC? 11/0x0B or 13/0x0D? #75

Open
guyharris opened this issue Aug 22, 2023 · 1 comment

Comments

@guyharris
Copy link

guyharris commented Aug 22, 2023

The I-D doesn't say what the Type field value is for ACK packets (and, as far as I can tell, never did).

Luigi Rizzo's PGM implementations for FreeBSD, with PGMCC, and patch for tcpdump at https://web.archive.org/web/20020302084503/http://info.iet.unipi.it/~luigi/pgm-code/ have the Type field value as 11/0x0B, as does the code submitted to tcpdump for its dissector.

This code, as well as the Wireshark dissector for PGM, has it as 13/0x0D, as does a PGMCC capture attached to https://gitlab.com/wireshark/wireshark/-/issues/4798.

Are they just two different codes for the same packet (which is what I made the tcpdump PGM dissector handle, and what I'm going to make the Wireshark PGM dissector handle)?

Or are they two different flavors of ACK that have to be dissected differently?

@steve-o
Copy link
Owner

steve-o commented Aug 25, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants