Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ts-standard #106

Closed
wants to merge 1 commit into from
Closed

feat: add ts-standard #106

wants to merge 1 commit into from

Conversation

pyrho
Copy link

@pyrho pyrho commented Oct 3, 2023

Thanks for the plugin !

Cheers.

edit: actually it's not working yet 😬 , converting to draft until I figure it out.

@pyrho pyrho marked this pull request as draft October 3, 2023 22:14
@pyrho pyrho closed this Oct 3, 2023
@pyrho
Copy link
Author

pyrho commented Oct 3, 2023

There's currently an issue with standard which prevents feeding files from stdin, see standard/ts-standard#273 .
Discarding this for now. Sorry for the noise.

@stevearc
Copy link
Owner

stevearc commented Oct 4, 2023

@pyrho did you try stdin = false? Conform supports formatters that don't accept stdin by writing a temp file and formatting it in-place.

@pyrho
Copy link
Author

pyrho commented Oct 5, 2023

Hey, just tried that but then there's another issue; it seems like ts-standard ignore hidden files by default.

File ignored by default.  Use a negated ignore pattern (like "--ignore-pattern '!<relative/path/to/filename>'") to override

I've tried all the combinations I could think of for the ignore pattern but I can't make it work, this message actually comes from eslint (which is used by ts-standard) so my gut tells me that ts-standard does not propagate the command line option all the way to eslint.

ts-standard feels a bit rough around the edges right now, might be worth revisiting in a year or two :)

In any case, thank you for conform!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants