Skip to content
This repository has been archived by the owner on Aug 27, 2023. It is now read-only.

Adding Azure Blob Storage support #241

Merged
merged 6 commits into from
May 21, 2020
Merged

Adding Azure Blob Storage support #241

merged 6 commits into from
May 21, 2020

Conversation

terricain
Copy link
Contributor

@terricain terricain commented May 11, 2020

Added tests, so it seems the way most of the azure sdk's test is by using vcrpy, which doesn't seem to work on < py36.

@coveralls
Copy link

coveralls commented May 11, 2020

Coverage Status

Coverage decreased (-0.04%) to 82.696% when pulling 8979edf on terrycain:feature/azure-blob-storage into cc203e7 on stevearc:master.

@terricain
Copy link
Contributor Author

Coverage is still unhappy about a -0.04% decrease, but I think the tests are fine

Copy link
Owner

@stevearc stevearc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! It's awesome to see people adding support for the tools they want to work with.

I have just a few requests for changes, but the overall structure and code looks good. Thanks so much for adding tests!

doc/topics/storage.rst Outdated Show resolved Hide resolved
pypicloud/storage/azure_blob.py Outdated Show resolved Hide resolved
pypicloud/storage/azure_blob.py Outdated Show resolved Hide resolved
pypicloud/storage/azure_blob.py Outdated Show resolved Hide resolved
@terricain
Copy link
Contributor Author

Cool fixed all that :)

@stevearc
Copy link
Owner

Awesome, thanks! Merged into the 1.0 branch and it'll go out in the next release

@terricain
Copy link
Contributor Author

Cool, any rough timescale on that :)

@stevearc
Copy link
Owner

You can expect it by the end of the next weekend

@terricain
Copy link
Contributor Author

Cool thanks

@stevearc stevearc merged commit 8db7021 into stevearc:master May 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants