This repository has been archived by the owner on Aug 27, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 141
Adding Azure Blob Storage support #241
Merged
stevearc
merged 6 commits into
stevearc:master
from
terricain:feature/azure-blob-storage
May 21, 2020
Merged
Adding Azure Blob Storage support #241
stevearc
merged 6 commits into
stevearc:master
from
terricain:feature/azure-blob-storage
May 21, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test get_storage_impl
Coverage is still unhappy about a -0.04% decrease, but I think the tests are fine |
stevearc
suggested changes
May 13, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! It's awesome to see people adding support for the tools they want to work with.
I have just a few requests for changes, but the overall structure and code looks good. Thanks so much for adding tests!
…icloud into feature/azure-blob-storage
Cool fixed all that :) |
Awesome, thanks! Merged into the 1.0 branch and it'll go out in the next release |
Cool, any rough timescale on that :) |
You can expect it by the end of the next weekend |
Cool thanks |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added tests, so it seems the way most of the azure sdk's test is by using vcrpy, which doesn't seem to work on < py36.