Updated website #54
Merged
Updated website #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| <script src="https://ajax.googleapis.com/ajax/libs/jquery/1.11.3/jquery.min.js"></script> | ||
| <script src="https://maxcdn.bootstrapcdn.com/bootstrap/3.3.5/js/bootstrap.min.js"></script> | ||
| <script src="https://cdn.rawgit.com/google/code-prettify/master/loader/run_prettify.js"></script> | ||
| <script src="bower_components/jquery.hotkeys/jquery.hotkeys.js"></script> |
There was a problem hiding this comment.
We can probably use the CDN version of this too?
There was a problem hiding this comment.
I looked for an offical CDN but didn't find one. Do you know of one that I don't?
There was a problem hiding this comment.
@steveathon I'm in the process of submitting a PR to the cdnjs.com repo containing the jQuery.hotkeys library. As soon as I get it done and it's approved I'll update my code to use the CDN link and I'll remove Bower while I'm at it.
|
This is good to go. I've merged it in. Thanks for the great work on this @RandomlyKnighted |
steveathon
added a commit
that referenced
this pull request
Aug 28, 2015
Added bower.json file Fixes #29 and #39 by adding a live demo to the website Removed bower since we use CDN for links Switched Google Code Prettify to CDN Migrated jquery.hotkeys from manual management to management using bower Changed folder structure and updated bootstrap-wysiwyg to newly released Updated basic usage section and included syntax highlighting
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #29, and #39 by adding a live demo to the website. In order to do this I made the Jekyll template Bootstrap 3 compatible. I migrated all dependencies over to CDN except for jQuery.hotkeys. Since jQuery.hotkeys does not have a CDN I added it using bower so that it does not have to be managed manually.
Finally, I have updated the website so that the basic usage now contains all the information on the Mindmup website. This way all the information is contained on one page and doesn't have to point to the Mindmup website other than to show that this repo was originally made by them.