This repository has been archived by the owner on May 20, 2020. It is now read-only.
Implement --quiet flag #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgattozzi
reviewed
Aug 25, 2017
src/cargo.rs
Outdated
| let (mut libs, mut bins): (Vec<_>, Vec<_>) = | ||
| targets.into_iter().partition(|target| match target.kind { | ||
| TargetKind::Library => true, | ||
| TargetKind::Binary => false, | ||
| }); | ||
|
|
||
| if !libs.is_empty() { | ||
| println!("Documenting the library."); | ||
| ui.warn( | ||
| "Found more than one target to document. Documenting the library.", |
There was a problem hiding this comment.
It might be good to say which library
There was a problem hiding this comment.
Actually disregard you can only have one library, but having the actual name would be useful
| use serde_json; | ||
|
|
||
| use error::*; | ||
| use ui::Ui; |
src/lib.rs
Outdated
| @@ -56,14 +60,15 @@ impl Config { | |||
| /// ## Arguments | |||
| /// | |||
| /// - `manifest_path`: The path to the `Cargo.toml` of the crate being documented | |||
| pub fn new(manifest_path: PathBuf, assets: Vec<Asset>) -> Result<Config> { | |||
| pub fn new(quiet: bool, manifest_path: PathBuf, assets: Vec<Asset>) -> Result<Config> { | |||
There was a problem hiding this comment.
maybe this should be an enum of levels instead; quiet, verbose, and normal?
There was a problem hiding this comment.
I agree. What if in the future we want -vvv? Having an enum would make that easier and is more type safe. It'll express what it does better.
|
Comments addressed. |
steveklabnik
approved these changes
Aug 27, 2017
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc #128
Also lays the groundwork for
--verboseonce we figure out how we want it to work.