Fix duplicate page with hidden title

#1445

OneMore/Commands/Page/DuplicatePageCommand.cs

@@ -33,17 +33,33 @@ public override async Task Execute(params object[] args)
 
 			// set the page ID to the new page's ID
 			page.Root.Attribute("ID").Value = newId;
+
 			// remove all objectID values and let OneNote generate new IDs
 			page.Root.Descendants().Attributes("objectID").Remove();
 			page = new Page(page.Root); // reparse to refresh PageId
 
 			var section = await one.GetSection(sectionId);
 
 			var editor = new SectionEditor(section);
+
+			// restore Title if it's hidden; the Interop API doesn't let us delete Title!
+			if (page.Title is null)
+			{
+				page.SetTitle(page.Root.Attribute("name").Value);
+			}
+
 			editor.SetUniquePageTitle(page);
 
 			await one.Update(page);
 
+			// FOLLOWING DOESN'T WORK; INTEROP API DOESN'T LET US HIDE (DELETE) Title
+			//if (hiddenTitle)
+			//{
+			//	page = await one.GetPage(page.PageId);
+			//	page.Root.Elements(ns + "Title").Remove();
+			//	await one.Update(page);
+			//}
+
 			if (editor.MovePageAfterAnchor(page.PageId, originalId))
 			{
 				one.UpdateHierarchy(section);

OneMore/Commands/Page/ExtractContentCommand.cs

@@ -54,6 +54,12 @@ public override async Task Execute(params object[] args)
 				return;
 			}
 
+			// restore Title if it's hidden; the Interop API doesn't let us delete Title!
+			if (page.Title is null)
+			{
+				page.SetTitle(page.Root.Attribute("name").Value);
+			}
+
 			var editor = new PageEditor(page);
 			var content = await editor.ExtractSelectedContent();
 

OneMore/Models/Page.cs

@@ -1366,12 +1366,17 @@ public void SetTitle(string title)
 				block = new XElement(ns + "Title",
 					new Paragraph(title).SetQuickStyle(style.Index));
 
-				var outline = Root.Elements(ns + "Outline")
-					.FirstOrDefault(e => !e.Elements(ns + "Meta")
-						.Any(m => m.Attribute("name").Value.Equals(MetaNames.TaggingBank)));
-
-				outline ??= EnsureContentContainer();
-				outline.AddBeforeSelf(block);
+				var anchor = Root.Elements(ns + "PageSettings").FirstOrDefault();
+				if (anchor is not null)
+				{
+					anchor.AddAfterSelf(block);
+				}
+				else
+				{
+					anchor = Root.Elements(ns + "Outline").FirstOrDefault();
+					anchor ??= EnsureContentContainer();
+					anchor.AddBeforeSelf(block);
+				}
 			}
 			else
 			{

OneMore/Models/SectionEditor.cs

@@ -177,6 +177,7 @@ public bool SetUniquePageTitle(Page page)
 			{
 				// shouldn't happen?
 				page.Title = $"{page.Title} ({index})";
+				page.Root.SetAttributeValue("name", page.Title);
 				return false;
 			}
 
@@ -222,6 +223,7 @@ public bool SetUniquePageTitle(Page page)
 			}
 
 			page.Title = title;
+			page.Root.SetAttributeValue("name", title);
 			return true;
 		}
 	}