asynchrofy the async validation of favorites

#1446

OneMore/Commands/Favorites/FavoritesDialog.cs

@@ -76,15 +76,16 @@ private void ValidateOnCellFormatting(object sender, DataGridViewCellFormattingE
  gridView.Rows[e.RowIndex].Cells[e.ColumnIndex].ToolTipText =
  Resx.Favorites_unknown;
 
- e.CellStyle.BackColor = Color.Pink;
+ e.CellStyle.ForeColor = manager.GetColor("ErrorText");
  e.FormattingApplied = true;
  }
  else if (favorite.Status == FavoriteStatus.Suspect)
  {
  gridView.Rows[e.RowIndex].Cells[e.ColumnIndex].ToolTipText =
  Resx.Favorites_suspect;
 
- e.CellStyle.BackColor = Color.LightGoldenrodYellow;
+ e.CellStyle.BackColor = manager.GetColor("Info");
+ e.CellStyle.ForeColor = manager.GetColor("InfoText");
  e.FormattingApplied = true;
  }
  }

OneMore/Commands/Settings/FavoritesSheet.cs

@@ -23,6 +23,7 @@ internal partial class FavoritesSheet : SheetBase
  private readonly IRibbonUI ribbon;
  private readonly bool shortcuts;
  private BindingList<Favorite> favorites;
+ private Task validator;
  private bool updated = false;
 
 
@@ -65,13 +66,30 @@ private async void LoadData(object sender, EventArgs e)
 
  await using var provider = new FavoritesProvider(null);
  var list = provider.LoadFavorites();
- await provider.ValidateFavorites(list);
+
+ // capture Task so it can be completed later in RowEnter
+ validator = provider.ValidateFavorites(list);
+
  favorites = new BindingList<Favorite>(list);
 
  gridView.DataSource = favorites;
  }
 
 
+ private async void FinishValidationOnRowEnter(object sender, DataGridViewCellEventArgs e)
+ {
+ // executed once (by unsetting 'validator') to update the data source binding
+ // after validation is completed
+
+ if (validator is not null)
+ {
+ await Task.WhenAll(validator);
+ validator = null;
+ favorites.ResetBindings();
+ }
+ }
+
+
  private void FormatCell(object sender, DataGridViewCellFormattingEventArgs e)
  {
  if (gridView.Rows[e.RowIndex].DataBoundItem is Favorite favorite)