Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a "Disable Spellcheck" (or "Keep Proofing Language") Option to Custom Styles #1191

Closed
Ziflin opened this issue Nov 29, 2023 · 7 comments · Fixed by #1195 or #1202
Closed

Add a "Disable Spellcheck" (or "Keep Proofing Language") Option to Custom Styles #1191

Ziflin opened this issue Nov 29, 2023 · 7 comments · Fixed by #1195 or #1202
Assignees
Labels
feature-request New feature or request released Available in a released installer

Comments

@Ziflin
Copy link

Ziflin commented Nov 29, 2023

Problem to Solve

I've been using Onetastic for years solely to have one custom style for "inline code" (such as this text) and another for HTML-pasted "code" snippets and both disable spell checking. To get this to work I simply need to have it apply the "Proofing Language" with the styles and have the language set to Latin/etc. similar to how OneMore's custom colorizer does it (#216).

New Feature/Solution

Ideally there would be a new option in the Custom Style "Options" section to "Disable Spellchecking" as that is the actual intent. Then OneMore could set the Proofing Language when applying the style similar to how it does with the colorizer.

@stevencohn stevencohn added the feature-request New feature or request label Nov 29, 2023
@stevencohn
Copy link
Owner

stevencohn commented Nov 29, 2023

Just a clarification... OneMore does disable spell checking when you use the Colorize command for inline code. By selecting a run of text within a paragraph and then using the Colorize/lang command, it will apply the primary font chosen in Settings and disable spell check for the affected text (setting the proofing language to Yoruba, with my sincerest apologies to the Yorubians!)

Styles are just that and have no association with coding languages. So I think your title is correct, asking for a disable spellcheck option for styles. But considering you get the same functionality by using the Colorize command, do you still need this option on custom styles?

@Ziflin
Copy link
Author

Ziflin commented Nov 29, 2023

The way I've been using it is for things like filenames/directory names, class names, menu names, etc. that aren't really code, but are things I need to constantly disable spell check on and set a custom style to (monospace font + font size + font color for filenames / directories and maybe italics + another font color for class names). These might appear several times in a single paragraph, so something that can be hot-keyed per style would be best.

I don't really need the Colorize behavior as there's no real coding language to pick, and in several cases I just need a style that disables spell checking (for the case of where I paste a pre-formatted HTML snippet of code and I just want OneNote to not spell check it).

So it seemed like just an option on the Custom Styles to disable Spell Check was more appropriate as I'm not really trying to format existing code in these cases.

@stevencohn stevencohn self-assigned this Nov 30, 2023
@stevencohn stevencohn linked a pull request Nov 30, 2023 that will close this issue
@stevencohn stevencohn added the next-release Addressed but not yet released label Nov 30, 2023
@Ziflin
Copy link
Author

Ziflin commented Nov 30, 2023

Awesome! Thanks for adding it! Look forward to the next release.

weissm pushed a commit to weissm/OneMore that referenced this issue Dec 1, 2023
weissm pushed a commit to weissm/OneMore that referenced this issue Dec 1, 2023
weissm pushed a commit to weissm/OneMore that referenced this issue Dec 1, 2023
weissm pushed a commit to weissm/OneMore that referenced this issue Dec 1, 2023
weissm pushed a commit to weissm/OneMore that referenced this issue Dec 1, 2023
weissm pushed a commit to weissm/OneMore that referenced this issue Dec 1, 2023
weissm pushed a commit to weissm/OneMore that referenced this issue Dec 1, 2023
weissm pushed a commit to weissm/OneMore that referenced this issue Dec 1, 2023
weissm pushed a commit to weissm/OneMore that referenced this issue Dec 1, 2023
weissm pushed a commit to weissm/OneMore that referenced this issue Dec 1, 2023
weissm pushed a commit to weissm/OneMore that referenced this issue Dec 1, 2023
@stevencohn
Copy link
Owner

While implemented for the next release, there is a newly discovered OneNote defect, as described by this tech note question.

@Ziflin
Copy link
Author

Ziflin commented Dec 2, 2023

I'm not sure if it's at all related to that OneNote bug, but I did notice that selecting a word than has been turned into a hyperlink (to a website URL), and then clicking the OneMore button to "Disable spell checking with selected content" will apply the proofing language to the entire page instead of just the selection. (If the hyperlink is created after disabling spell check, it works fine.) I can create a new issue for that if need be.

@stevencohn
Copy link
Owner

No you're right. This is a OneMore bug, not OneNote.

It is due to the fact that OneMore can't tell the difference between a selected text range within a hyperlink and simply placing the text cursor over a hyperlink; even without selecting one or more characters, OneNote indicates that the entire hyperlink is selected. So OneMore has logic to handle this exception, however, the bug you mention above can be fixed and I will do that against this ticket. No need for a new one.

stevencohn added a commit that referenced this issue Dec 3, 2023
@stevencohn stevencohn linked a pull request Dec 3, 2023 that will close this issue
@stevencohn
Copy link
Owner

@Ziflin This will be fixed in the next release. Note however that if only the hyperlink is selected (whether fully, partially, or just because the cursor is on it) then the whole page will be affected. But if even one extra non-hyperlinked character is included then only that range will be affected.

weissm pushed a commit to weissm/OneMore that referenced this issue Dec 5, 2023
weissm pushed a commit to weissm/OneMore that referenced this issue Dec 5, 2023
weissm pushed a commit to weissm/OneMore that referenced this issue Dec 5, 2023
weissm pushed a commit to weissm/OneMore that referenced this issue Dec 5, 2023
weissm pushed a commit to weissm/OneMore that referenced this issue Dec 5, 2023
weissm pushed a commit to weissm/OneMore that referenced this issue Dec 5, 2023
weissm pushed a commit to weissm/OneMore that referenced this issue Dec 5, 2023
weissm pushed a commit to weissm/OneMore that referenced this issue Dec 5, 2023
weissm pushed a commit to weissm/OneMore that referenced this issue Dec 5, 2023
weissm pushed a commit to weissm/OneMore that referenced this issue Dec 5, 2023
weissm pushed a commit to weissm/OneMore that referenced this issue Dec 5, 2023
weissm pushed a commit to weissm/OneMore that referenced this issue Dec 5, 2023
weissm pushed a commit to weissm/OneMore that referenced this issue Dec 5, 2023
weissm pushed a commit to weissm/OneMore that referenced this issue Dec 5, 2023
weissm pushed a commit to weissm/OneMore that referenced this issue Dec 5, 2023
weissm pushed a commit to weissm/OneMore that referenced this issue Dec 5, 2023
weissm pushed a commit to weissm/OneMore that referenced this issue Dec 5, 2023
weissm pushed a commit to weissm/OneMore that referenced this issue Dec 5, 2023
weissm pushed a commit to weissm/OneMore that referenced this issue Dec 5, 2023
weissm pushed a commit to weissm/OneMore that referenced this issue Dec 5, 2023
weissm pushed a commit to weissm/OneMore that referenced this issue Dec 5, 2023
weissm pushed a commit to weissm/OneMore that referenced this issue Dec 5, 2023
weissm pushed a commit to weissm/OneMore that referenced this issue Dec 5, 2023
weissm pushed a commit to weissm/OneMore that referenced this issue Dec 5, 2023
weissm pushed a commit to weissm/OneMore that referenced this issue Dec 5, 2023
weissm pushed a commit to weissm/OneMore that referenced this issue Dec 5, 2023
weissm pushed a commit to weissm/OneMore that referenced this issue Dec 5, 2023
@stevencohn stevencohn added released Available in a released installer and removed next-release Addressed but not yet released labels Dec 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request New feature or request released Available in a released installer
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants