Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hashtags - Feature to permanent "Color hashtags" #1236

Closed
nhwCoder opened this issue Dec 23, 2023 · 2 comments · Fixed by #1241
Closed

Hashtags - Feature to permanent "Color hashtags" #1236

nhwCoder opened this issue Dec 23, 2023 · 2 comments · Fixed by #1241
Assignees
Labels
feature-request New feature or request released Available in a released installer
Milestone

Comments

@nhwCoder
Copy link

New Feature/Solution

Propose a feature to be able to permanent "Color hashtags".
Colored hashtags in the page would help a lot to see immediately which parts have been tagged and for what reason (see attached screenshot (1) versus (2) ).
11111111111111

Additional Context

Text-color vs. background-color

I think to set the text color is better (compared to background color).
Like in screenshot with number (2), so that you can see your defined ##hashtags in color immediately.

UI options
  1. MAYBE even one control called "Color hashtags" with a color picker in the current UI would be sufficient to change all ##hashtag colors.
  2. Or put it in the "..." menu (top right-side).
  3. Or a new menu entry "Color hashtags" with a color-picker to choose one color or no color (none).
Scope

Since you have all ##hashtags in SqlLite I would propose to always change all ##hashtags if someone changes the color.
Maybe with the choice for page/section/notebook/all notebooks

Keyboard shortcut

Very important: Adding a keyboard shortcut.

Use case: User adds a new ##hashtag and then presses the keyboard shortcut to have the ##hashtags colored.
Tricky: Maybe to have one keyboard shortcut for "page" (faster and sufficient in this case) and another for "all notebooks".

@PaulJamesTaylor
Copy link

  • Highlight should be to the text and not the background for aesthetic reasons
  • Obsidian just auto sets the tag to a default color, this works pretty well I think (user can define that color)
    • user shouldn't be required to set the color after creating the hashtag, it should be automatically colored (optional)

stevencohn added a commit that referenced this issue Dec 27, 2023
@stevencohn stevencohn self-assigned this Dec 28, 2023
@stevencohn stevencohn linked a pull request Dec 28, 2023 that will close this issue
@stevencohn stevencohn added feature-request New feature or request next-release Addressed but not yet released labels Dec 28, 2023
@stevencohn
Copy link
Owner

stevencohn commented Dec 28, 2023

Added user setting to choose preferred hashtag styling

  • None (will not remove styling from stylized hashtags because that may have been done manually)
  • Red foregound
  • Yellow background
  • Or any of your user-defined custom styles of type Character

These styles are applied to new hashtags as they are discovered by the background scanner or the on-demand menu item.

image

weissm pushed a commit to weissm/OneMore that referenced this issue Dec 28, 2023
weissm pushed a commit to weissm/OneMore that referenced this issue Dec 28, 2023
weissm pushed a commit to weissm/OneMore that referenced this issue Dec 28, 2023
weissm pushed a commit to weissm/OneMore that referenced this issue Dec 28, 2023
weissm pushed a commit to weissm/OneMore that referenced this issue Dec 28, 2023
weissm pushed a commit to weissm/OneMore that referenced this issue Dec 28, 2023
@stevencohn stevencohn added released Available in a released installer and removed next-release Addressed but not yet released labels Jan 21, 2024
@stevencohn stevencohn added this to the 6.2.1 milestone Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request New feature or request released Available in a released installer
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants