Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please add colorizing support for php #1325

Closed
abtzero opened this issue Mar 15, 2024 · 8 comments · Fixed by #1367
Closed

Please add colorizing support for php #1325

abtzero opened this issue Mar 15, 2024 · 8 comments · Fixed by #1367
Assignees
Labels
feature-request New feature or request released Available in a released installer
Milestone

Comments

@abtzero
Copy link

abtzero commented Mar 15, 2024

What a great Add-in! Can't live without it. Great job!

CSS, HTML, XML, javascript are there, so very important: PHP is missing.

I tried to add by myself by adding php.png (16x16) and a php.json into Colorizer\Languages, restartet OneNote, but it doers not show up in the UI-list.
Needs it to be compiled?
Or do I have to de-activate and activate the addin on OneNote first?

Anyway, I started with the csharp.json and replaced the list of keywords.
That is the only change I made. It might not be perfect

P.P.
I started with the selection "Feature request", but my post did not get this label, and I can't add it later on...

@stevencohn
Copy link
Owner

Check the %temp%\OneMore.log file. There may be a syntax error in the json??

@abtzero
Copy link
Author

abtzero commented Mar 15, 2024

Thanks a lot!

I did not know the log file.
YES!
It worked! It was a missing " in the json.
Now I see that my keyword list is missing some expressions, but in general it works!
I need to tweak my jason, but i am on my way. I could share it here so that You can add it to the next version.

Is there a file to change the syntax colours for Comments, variables, etc?

@stevencohn
Copy link
Owner

stevencohn commented Mar 15, 2024

There is a Themes folder adjacent to the Languages folder. Hopefully, there are enough classifications of colors in there already; they are all shared amongst the languages so if PHP has something specific, it would be best to create a new classification.

You can share changes here or submit a PR to this repo.

@abtzero
Copy link
Author

abtzero commented Mar 15, 2024

Found it!

@stevencohn stevencohn added question Further information is requested answered Question answered, no more to do labels Mar 15, 2024
@stevencohn
Copy link
Owner

Hey @abtzero! If you have the php config files, feel free to open a pull request. Or attach them here and I'll include them in the next release.

@yuganglidemao
Copy link

@abtzero Can you provide php.json download, thank you!

@abtzero
Copy link
Author

abtzero commented Apr 9, 2024 via email

@stevencohn stevencohn self-assigned this Apr 27, 2024
stevencohn added a commit that referenced this issue Apr 27, 2024
stevencohn added a commit that referenced this issue Apr 27, 2024
@stevencohn stevencohn linked a pull request Apr 27, 2024 that will close this issue
@stevencohn stevencohn added next-release Addressed but not yet released feature-request New feature or request and removed question Further information is requested answered Question answered, no more to do labels Apr 27, 2024
@stevencohn
Copy link
Owner

stevencohn commented Apr 27, 2024

Added a PHP language definition file here. It's not entirely complete but should highlight the important bits. I'd appreciate suggestions to improve its coverage.

@stevencohn stevencohn added this to the 6.3.0 milestone Apr 29, 2024
@stevencohn stevencohn added released Available in a released installer and removed next-release Addressed but not yet released labels May 5, 2024
weissm pushed a commit to weissm/OneMore that referenced this issue May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request New feature or request released Available in a released installer
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants