Markdown improvements regarding tables, nested statements and special character support in links #1647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squased Markdown commits Revert "squased Markdown commits" This reverts commit 615c88d. removed spaces Update InsertBoxCommand.cs merged input squased Markdown commits squased Markdown commits Revert "squased Markdown commits" This reverts commit 615c88d. removed spaces Update InsertBoxCommand.cs merged input Revert "Merge branch 'improveMarkdown' of github.com:weissm/OneMore into improveMarkdown" This reverts commit c296f72. Merge branch 'improveMarkdown' of github.com:weissm/OneMore into improveMarkdown Revert "squased Markdown commits" This reverts commit 93411d9. Revert "Added nested table example" This reverts commit d5d0122. Added nested table example Added nested table example
weissm
changed the title
|
I will take a look at this. Just need a little time. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IS YOUR COMMIT SIGNED?
yes
Enhancement or Defect Addressed by This PR
Enhancement
Description of Proposed Changes
When generating markdown nested tables the handled was not done properly. Also the handling of numbered list in tables was not properly processed.
The following changes are applied:
<>. To protect these characters, theReplacestatement is moved before.The push requested was tested on the OneNote TextToTable. For clarification another example onenote page NestedTableContent is added.