Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support react-i18next v12 #15

Merged
merged 1 commit into from
Mar 17, 2023
Merged

Conversation

sawyerh
Copy link
Contributor

@sawyerh sawyerh commented Dec 5, 2022

This should fix #14.

The only change in v12 of react-18next was a behind-the-scenes change related to TypeScript, so this should be safe to support without any changes to storybook-react-i18next. I believe they did a major version release because it dropped support for TypeScript versions below 4.1.

@mheob
Copy link

mheob commented Dec 23, 2022

@stevensacks Can this be merged? It has been blocking us from updating react-18next for quite a while.

@stevensacks
Copy link
Owner

@mheob I apologize for my absence on this. I have merged it.

@sawyerh sawyerh deleted the sawyerh/fix-14 branch March 17, 2023 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When react-i18next is updated to 12.0.0, we get npm ERR! ERESOLVE could not resolve on npm install
3 participants