Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

createMeta helper #3

Merged
merged 7 commits into from
May 17, 2022
Merged

createMeta helper #3

merged 7 commits into from
May 17, 2022

Conversation

GRA0007
Copy link
Member

@GRA0007 GRA0007 commented May 16, 2022

  • Cleaned up some code
  • Add some typings
  • Changed to relative imports (because this is a small project)
  • Enhanced the readme
  • Created the createMeta helper (see readme in helpers)

@GRA0007 GRA0007 requested a review from giraugh May 16, 2022 16:53
@GRA0007 GRA0007 self-assigned this May 16, 2022
giraugh
giraugh approved these changes May 17, 2022
View reviewed changes
Copy link
Member

@giraugh giraugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good. Rip my absolute imports tho 😢. Readme and library changes very hype 👌
Approved but we should change that localhost output thing

src/server.ts Outdated Show resolved Hide resolved
@GRA0007 GRA0007 merged commit ed7b705 into main May 17, 2022
@GRA0007 GRA0007 deleted the feat/helpers branch May 17, 2022 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giraugh giraugh giraugh approved these changes

Assignees

@GRA0007 GRA0007

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GRA0007 @giraugh