feat(ssr)(backport v16): adds server cookie output via response #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
@pavankjadda this should now be ready for review. Sorry for the wait. |
|
@pavankjadda anything I need to do for this PR? I see a check failed, but that check was also failing against dependabot's PRs too. So not sure if that's an actual issue. |
blakeoxx
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix/feature resolves #266 . It increases the
SsrCookieServices ability to use the request and response objects provided by Express to read and write cookies on the server side. This also means that cookies written during SSR will be returned to the client in the response headers.This PR is intended for a future release of v16 (16.2.0), up to maintainer discretion. If this PR passes code review, I can also port these changes forward to v17.
This PR was originally represented in #304, but was closed to resolve some attribution issues.