Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow authentication via URI query parameter #642

Commits on Aug 26, 2024

  1. Allow authentication via URI query parameter

    Introduce new annotation for resources that makes the authentication
    filter look at the URI query for a parameter containing the API key
    instead of a header.
    This enables clients that cannot supply headers to use authentication-
    locked resources.
    
    Signed-off-by: Kirill.Sybin <kirill.sybin@lex-com.net>
    Kirill.Sybin committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    7e9e655 View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2024

  1. Rename new annotation

    Renaming as per reviewer suggestion to better reflect its purpose:
    stevespringett#642 (comment)
    
    Signed-off-by: Kirill.Sybin <kirill.sybin@lex-com.net>
    Kirill.Sybin committed Aug 31, 2024
    Configuration menu
    Copy the full SHA
    8694e19 View commit details
    Browse the repository at this point in the history
  2. Rework logic picking query over header for APi key

    Implement reviewer suggestion to replace either-or logic of looking at
    the URI query parameter instead of the header into a hierarchy, which
    keeps the header as the preferred location for the API key in every case
    and makes the query parameter the opt-in alternative that's enabled by
    the annotation.
    Review:
    stevespringett#642 (comment)
    
    Signed-off-by: Kirill.Sybin <kirill.sybin@lex-com.net>
    Kirill.Sybin committed Aug 31, 2024
    Configuration menu
    Copy the full SHA
    a3c3b52 View commit details
    Browse the repository at this point in the history