Add notebook for setting up LLM training environment #78
+54
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the pytorch notebook as a base for the llm notebook. Created an empty .sh file for adding installation script
Docerfile includes steps for copying and running the script. Script renamed to make it clear what dependencies are being installed
anish-mudaraddi
previously approved these changes
Nov 20, 2024
| RUN chown ${NB_UID} /home/${NB_USER}/install-sciml-deps.sh | ||
| RUN chmod +rx /home/${NB_USER}/install-sciml-deps.sh | ||
|
|
||
| USER $NB_UID |
There was a problem hiding this comment.
Why is this line $NB_UID while other lines use ${NB_UID}? Will that make a difference?
There was a problem hiding this comment.
While technically you can do that - for simplicity you don't need to - makes it easier to read
There was a problem hiding this comment.
The curly braces protect the variable, it's something that is optional to put around bash variables
The original directory was being hidden on JupyterHub by Longhorn, moving it to a different location to download the model
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new LLM specific notebook. This is similar to the pytorch notebook, but with a script containing installation steps that are required for the training environment.