Start adding types and cleaning up classes.py #28
Conversation
also start cleaning up stashapp.py and stashbox.py a little bit added a `get_logger` method to log.py which can be used instead of `import stashapi.log as log`
| import stashapi.log as logger | ||
|
|
||
| self.log = logger | ||
| super().__init__(conn.get("Logger", None) or get_logger()) |
There was a problem hiding this comment.
Is there ever actually a logger in the connection parameters? If so, what does it look like? The documentation on the plugin task inputs doesn't mention this field:
Plugin task input
Plugin tasks may accept an input from the stash server. This input is encoded according to the interface, and has the following structure (presented here in JSON format):
{
"server_connection": {
"Scheme": "http",
"Port": 9999,
"SessionCookie": {
"Name":"session",
"Value":"cookie-value",
"Path":"",
"Domain":"",
"Expires":"0001-01-01T00:00:00Z",
"RawExpires":"",
"MaxAge":0,
"Secure":false,
"HttpOnly":false,
"SameSite":0,
"Raw":"",
"Unparsed":null
},
"Dir": ,
"PluginDir": ,
},
"args": {
"argKey": "argValue"
}
}
The server_connection field contains all the information needed for a plugin to access the parent stash server, if necessary.
There was a problem hiding this comment.
logger is a non standard input that is indented to be passed from a plugin so that the log config consistent
There was a problem hiding this comment.
Ok cool that was my guess, I think this should work then
also start cleaning up stashapp.py and stashbox.py a little bit
added a
get_loggermethod to log.py which can be used instead ofimport stashapi.log as logTotally untested so far