Fix js message pivot selection (#6813) #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix javascript setFieldIgnoringDefault_ logic * remove package-lock.json * fix build script to include new UT asset file Co-authored-by: Daniel Kurka <kurka.daniel@gmail.com>
sthagen
pushed a commit
that referenced
this pull request
Oct 9, 2024
…uilder at return. See godbolt for Android ART compiler: https://godbolt.org/z/M9dWhdqbf This optimisation brings the implementation down from 284 bytes to 272 bytes. - `GeneratedMessage$Builder SingleFieldBuilder.getBuilder() [284 bytes]` - `GeneratedMessage$Builder SingleFieldBuilder.getBuilder__withLocalVariable() [272 bytes]` It's not big. It's just a few instructions dropped. These were dropped just before the `ret`: ``` -mov x23, x1 -ldr w0, [x23, #8] ``` And this load dropped before calling `markClean`. ``` -ldr w1, [x23, #8] ``` PiperOrigin-RevId: 683619150
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix javascript setFieldIgnoringDefault_ logic
remove package-lock.json
fix build script to include new UT asset file
Co-authored-by: Daniel Kurka kurka.daniel@gmail.com