Fix dependence of Uniform logp on bound method (#4541) #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix logp of (Discrete) Uniform to not depend on bound * Add unittest * Remove redundant `all()` bound conditions in multivariate distributions and improve documentation of dist_math::bound * Add recommendation for check_bounds. * Add release note * Include Release Notes from 3.11.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
all()bound conditions in multivariate distributions and improve documentation of dist_math::boundThank your for opening a PR!
Depending on what your PR does, here are a few things you might want to address in the description: