Remove EncodedData replacing with Array<UInt8>
#20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #20 +/- ##
==========================================
- Coverage 99.45% 99.41% -0.04%
==========================================
Files 14 13 -1
Lines 918 857 -61
==========================================
- Hits 913 852 -61
Misses 5 5
|
- From `write(_ storageContainer: StorageContainer, to buffer: UnsafeMutableRawBufferPointer) -> Int` to `convert(_ storageContainer: StorageContainer) -> [UInt8]`.
- Remove byte count from element header. - Adjust alignment decreasing padding.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove
EncodedDataand replace withArray<UInt8>Motivation and Context
With the changes in the internal representation of EncodedData, it does not make sense to have an intermediate structure at this point. Removing EncodedData also creates an easier to understand interface as well as makes it simpler to add future binary formats if required.
How Has This Been Tested?
The existing tests cover the new changes and all tests pass.
Checklist:
For all changes:
in the commit message?
For code changes:
make testsin the cmake-build-debug` directory off the root of the project?For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.