Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: Support for GSSApi Authentication for SOCKS5 #41

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

RoKu1
Copy link
Contributor

@RoKu1 RoKu1 commented Jul 5, 2024

RFC Followed: GSSAPI Support RFC LINK

Code is written per RFC basis and has been reviewed internally,.
Any Ideas For testing this are welcome.

@RoKu1
Copy link
Contributor Author

RoKu1 commented Jul 11, 2024

@sticnarf Can we get this support added.

Cargo.toml Outdated Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
src/tcp/socks5.rs Outdated Show resolved Hide resolved
@sticnarf
Copy link
Owner

I find dante supports GSS-API. Are you interested in running a dante server and test this implementation against dante on GitHub Actions?

@RoKu1
Copy link
Contributor Author

RoKu1 commented Jul 16, 2024

Yeah that would be a good test, however, dante would provide socks5 side of things, how do we s=get the KDC server for test, is there any way to do this, I tried searching for any container based KDC/Kerberos, but could not find any

@sticnarf
Copy link
Owner

Is https://github.com/criteo/kerberos-docker a good reference? Seems they run kerberos on Github Actions.

@RoKu1
Copy link
Contributor Author

RoKu1 commented Jul 16, 2024

Will have a look. I am a bit unfamiliar with GitHub actions, however will try and see if we can do Dante and this kerberos deployment on actions itself for testing.

@RoKu1
Copy link
Contributor Author

RoKu1 commented Jul 18, 2024

Hi, https://github.com/criteo/kerberos-docker looks like a good candidate for KDC, I suppose what I need is, this being the KDC and then dante being the socks5 proxy, that should and then we run gssapi tests for client from out code. However still some issues that I am facing are how to propagate the context from KDC to dante, suppose we could hook up dante and kdc but then the code to actually get gssapi sec context tokens on client code how would that work out

@RoKu1
Copy link
Contributor Author

RoKu1 commented Oct 5, 2024

Hi @sticnarf , sorry I was away for long time, would this still be working, do you think we can add this support? I am aware that the test for it is left, but I was not able to do the setup for it. Can you help me out with it?

@RoKu1 RoKu1 force-pushed the feature_gssapi_auth_support_socks5 branch from 4a81f76 to 92d7ff4 Compare October 6, 2024 11:09
@sticnarf
Copy link
Owner

Hi @sticnarf , sorry I was away for long time, would this still be working, do you think we can add this support? I am aware that the test for it is left, but I was not able to do the setup for it. Can you help me out with it?

Sorry, but I am not familiar with GSS-API. I'm afraid I don't have enough time to set up a working GSS-API configuration to test this out.

Alternatively, can you find someone other who can manually test your PR?

@RoKu1
Copy link
Contributor Author

RoKu1 commented Oct 13, 2024

Sure NP, will try to do a manual test and share results, here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants