-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft: Support for GSSApi Authentication for SOCKS5 #41
base: master
Are you sure you want to change the base?
Conversation
@sticnarf Can we get this support added. |
I find dante supports GSS-API. Are you interested in running a dante server and test this implementation against dante on GitHub Actions? |
Yeah that would be a good test, however, dante would provide socks5 side of things, how do we s=get the KDC server for test, is there any way to do this, I tried searching for any container based KDC/Kerberos, but could not find any |
Is https://github.com/criteo/kerberos-docker a good reference? Seems they run kerberos on Github Actions. |
Will have a look. I am a bit unfamiliar with GitHub actions, however will try and see if we can do Dante and this kerberos deployment on actions itself for testing. |
Hi, https://github.com/criteo/kerberos-docker looks like a good candidate for KDC, I suppose what I need is, this being the KDC and then dante being the socks5 proxy, that should and then we run gssapi tests for client from out code. However still some issues that I am facing are how to propagate the context from KDC to dante, suppose we could hook up dante and kdc but then the code to actually get gssapi sec context tokens on client code how would that work out |
Hi @sticnarf , sorry I was away for long time, would this still be working, do you think we can add this support? I am aware that the test for it is left, but I was not able to do the setup for it. Can you help me out with it? |
4a81f76
to
92d7ff4
Compare
Sorry, but I am not familiar with GSS-API. I'm afraid I don't have enough time to set up a working GSS-API configuration to test this out. Alternatively, can you find someone other who can manually test your PR? |
Sure NP, will try to do a manual test and share results, here. |
RFC Followed: GSSAPI Support RFC LINK
Code is written per RFC basis and has been reviewed internally,.
Any Ideas For testing this are welcome.