Skip to content

Review notebook 9 "Timeseries" #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: review
Choose a base branch
from

Conversation

jorisvandenbossche
Copy link
Collaborator

No description provided.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

You'll be able to see Jupyter notebook diff and discuss changes. Powered by ReviewNB.

@@ -0,0 +1,1004 @@
{

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At this point in the code, you have already renamed "date.utc" to "datetime".


Reply via ReviewNB

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll make sure the source data is using datetime in order to have this as column label across all tutorials.

@@ -0,0 +1,1004 @@
{
Copy link

@justmarkham justmarkham Oct 2, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

xustom -> custom


Reply via ReviewNB

@@ -0,0 +1,1004 @@
{
Copy link

@justmarkham justmarkham Oct 2, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

powerfull -> powerful


Reply via ReviewNB

@@ -0,0 +1,1004 @@
{
Copy link

@justmarkham justmarkham Oct 2, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resample -> resample

powerfull -> powerful

functionality -> function


Reply via ReviewNB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants