-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review notebook 4 "Plotting data" #6
base: review
Are you sure you want to change the base?
Conversation
Check out this pull request on You'll be able to see Jupyter notebook diff and discuss changes. Powered by ReviewNB. |
@@ -0,0 +1,512 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -0,0 +1,512 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did this to overcome the potential confusion some new users might have with .plot(ax=ax)
which _feels_ like magic to them without realizing the left hand side is the method parameter and the right hand side is the ax object passed as argument. I propose to use axs
instead of ax
@@ -0,0 +1,512 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For this diagram, I'm not sure what to make of the blue and the green. On the left side, there are two green columns and one blue column. On the right, I see two blue plots (one of which has green lines) and one green plot. Am I supposed to make a connection between the left and the right? If not, maybe tweak the colors to be different.
Reply via ReviewNB
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The idea is actually that the single blue column is used to create a histogram and a boxplot: summary plots of a single column. The scatter plot provides the representation of 2 columns. Would it suffice to make the small green lines of the boxplots grey or would this still be confusing? Maybe just no coloring of columns would be the best? Other suggestions to improve this certainly welcome.
No description provided.