Skip to content

Review notebook 7 "Reshaping" #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: review
Choose a base branch
from

Conversation

jorisvandenbossche
Copy link
Collaborator

No description provided.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

You'll be able to see Jupyter notebook diff and discuss changes. Powered by ReviewNB.

@@ -0,0 +1,1654 @@
{
Copy link

@justmarkham justmarkham Sep 27, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The final sentence gets lost in this paragraph, even though I think it's something you were trying to emphasize.


Reply via ReviewNB

@@ -0,0 +1,1654 @@
{
Copy link

@justmarkham justmarkham Sep 27, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stating it this way makes it sound like the no2 dataset already exists. I would rephrase it to indicate that you are filtering the air_quality DataFrame in order to create a new DataFrame which only contains the NO2 measurements.


Reply via ReviewNB

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll move the filtering to the subsection where the data is effectively used instead of making it part of the introduction.

@@ -0,0 +1,1654 @@
{
Copy link

@justmarkham justmarkham Sep 27, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: "titanic date" should be "titanic data"

(This same typo is also below.)


Reply via ReviewNB

@@ -0,0 +1,1654 @@
{
Copy link

@justmarkham justmarkham Sep 27, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't quite follow what the last sentence in this paragraph means. I would recommend either cutting that sentence or perhaps demonstrating it.


Reply via ReviewNB

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll cut this as it is not adding added value explaining all these options in detail.

@@ -0,0 +1,1654 @@
{
Copy link

@justmarkham justmarkham Sep 27, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: "restructering" should be "restructuring" (or you could just say "reshaping")


Reply via ReviewNB

@@ -0,0 +1,1654 @@
{
Copy link

@justmarkham justmarkham Sep 27, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: "can to be used" should be "can be used"


Reply via ReviewNB

@@ -0,0 +1,1654 @@
{
Copy link

@justmarkham justmarkham Sep 27, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: "olumn" should be "column"


Reply via ReviewNB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants