-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup header header struct. #5
Conversation
Current header compilation time:
After this PR:
Yeah, that's pretty painful. I think the main culprit is |
The issue could be related to the issue discussed here: |
I have made some changes which make the reading much more tolerable. The data looks sensible too, based on my limited testing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks mostly good - I've also considered iteratively reading the setup struct as a OrderedDict{Symbol,Any}
, which might fractionally increase runtime, but would sharply decrease compilation time. That would also make it easier to handle the branches necessary to read older Setup
header formats.
Very slow to construct/read into. I think it's to do with the use of static arrays, but haven't found a fix yet. Not yet tested the validity of data.