Draft: Futurism updates-for support #166
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…its children using a selector
xtr3me
force-pushed
the
cable_ready_updates_for_futurism_compatibility
branch
from
69403ae
to
4c5de71
Compare
2 tasks
| }) | ||
| } | ||
|
|
||
| if (blocks[i].dataset.afterUpdateEventSelector) { |
There was a problem hiding this comment.
I think this should happen inside the onElUpdated too?
|
I'm closing this as a lot of time has since passed and the implementations diverged a bit. Feel free to message me if you still sense an enhancement is due here. We're cleaning up PRs for the 5.0 release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR accompanies the following Futurism PR: stimulusreflex/futurism#120
Since I found no other way to instruct morphdom to not mutate the futurism-element I introduced a data attribute to instruct the updates-for element to not call morphdom in the first place.
Secondly I introduced a data attribute that is used to emit a event to the provided selector. This allows futurism to listen to the event and call it's futurism actioncable channel and refresh it's partial without glitching