Introduce @cable_ready/polyfills and sync javascript changes from stimulus_reflex
#77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce `@cable_ready/polyfills` Move javascript/ to packages/@cable_ready/core Introduce microbundle for the package builds Applies all of the changes from stimulusreflex/stimulus_reflex#340, stimulusreflex/stimulus_reflex#315 and stimulusreflex/stimulus_reflex#345 to cable_ready
marcoroth
added a commit
to marcoroth/stimulus_reflex
that referenced
this pull request
Nov 3, 2020
|
We still need to clarify if and how we need to polyfill these:
caniuse.com says the first two are not compatible with IE11. |
3 tasks
marcoroth
force-pushed
the
polyfills-package
branch
from
d65f5b0 to
935fd41
Compare
|
Okay, it looks like |
Closed
|
Is https://adodson.com/notification.js/ a possible solution for Notification? |
marcoroth
force-pushed
the
polyfills-package
branch
from
7f54c11 to
b09b0a0
Compare
marcoroth
added a commit
to cableready/polyfills
that referenced
this pull request
May 5, 2021
|
Closing in favor of #165. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of PR
Feature
Description
This PR applies all of the changes from stimulusreflex/stimulus_reflex#340,
stimulusreflex/stimulus_reflex#315(reverted) and stimulusreflex/stimulus_reflex#345 tocable_ready.This includes:
@cable_ready/polyfillsjavascript/topackages/@cable_ready/coreWhy should this be added
Applies everything to the
cable_readyJavaScript part that was introduced to thestimulus_reflexJavaScript part. Including the same structure for multiple npm packages and polyfills package for the support of CableReady in older browsers.Checklist