Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore placeholders before turbolinks caches #23

Closed
julianrubisch opened this issue Jul 23, 2020 · 1 comment · Fixed by #57
Closed

Restore placeholders before turbolinks caches #23

julianrubisch opened this issue Jul 23, 2020 · 1 comment · Fixed by #57
Labels
enhancement New feature or request
Milestone

Comments

@julianrubisch
Copy link
Contributor

julianrubisch commented Jul 23, 2020

If a page is turbolinks-cached, it will show it in a flash, then render the futurism helpers.

However, if cached, it would preferable to simply use the cached version and halt everything.

Cf https://github.com/turbolinks/turbolinks#detecting-when-a-preview-is-visible, http://www.modernmpa.com/turbolinks

@julianrubisch julianrubisch added the enhancement New feature or request label Jul 23, 2020
@julianrubisch
Copy link
Contributor Author

cf https://dev.to/adrienpoly/animations-with-turbolinks-and-stimulus-4862

Contrary to my statement above, I now think the futurism-element's state should be restored to loading before navigation, so the cached version displays the loading elements.

@julianrubisch julianrubisch added this to the 0.5.0 milestone Aug 31, 2020
@julianrubisch julianrubisch modified the milestones: 0.5.0, 0.5.1 Sep 18, 2020
@julianrubisch julianrubisch changed the title If a page is turbolinks-cached, fall back to that Restore placeholders before turbolinks caches Oct 3, 2020
julianrubisch added a commit that referenced this issue Oct 6, 2020
julianrubisch added a commit that referenced this issue Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant